fix(ci): add libfdk-aac-dev to marketplace build dependencies#268
fix(ci): add libfdk-aac-dev to marketplace build dependencies#268streamer45 merged 1 commit intomainfrom
Conversation
Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y cmake pkg-config libclang-dev libfontconfig1-dev wget libopenblas-dev zstd patchelf python3-yaml python3-tomli | ||
| sudo apt-get install -y cmake pkg-config libclang-dev libfontconfig1-dev wget libopenblas-dev zstd patchelf python3-yaml python3-tomli libfdk-aac-dev |
There was a problem hiding this comment.
🚩 plugins.yml CI missing lint/format checks for aac-encoder
The plugins.yml workflow (.github/workflows/plugins.yml) has format and clippy lint jobs for most native plugins (vad, whisper, kokoro, piper, matcha, sensevoice, nllb, slint) but does not include the aac-encoder plugin. This means the aac-encoder plugin won't get format or clippy checks in CI. This is a pre-existing gap from the PR that added the aac-encoder plugin (#261), not introduced by this PR, but it's worth noting since this PR is specifically about making the aac-encoder build work in CI pipelines.
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
2 participants
Summary
The Marketplace Release CI fails at the "Build official plugins" step because the
aac-encoderplugin (added in #266) depends onshiguredo_fdk_aac, which requireslibfdk-aac-devheaders at build time. The CI system dependencies list was missing this package.This adds
libfdk-aac-devto theapt-get installstep inmarketplace-build.yml.Review & Testing Checklist for Human
libfdk-aac-devis available onubuntu-22.04runners (it is in the standard repos)Notes
This is the build-time counterpart to the runtime
libfdk-aac.so.2dependency already noted in the plugin metadata. Onlymarketplace-build.ymlneeds this —release.ymlbuilds the server binary, not plugins.Link to Devin session: https://staging.itsdev.in/sessions/b06b5b9799374229b9def639335b23b3
Requested by: @streamer45